Skip to content

bpo-41784: make PyUnicode_AsUTF8AndSize part of the limited API#22252

Merged
zooba merged 3 commits into
python:masterfrom
alex:expose-utf8
Oct 19, 2020
Merged

bpo-41784: make PyUnicode_AsUTF8AndSize part of the limited API#22252
zooba merged 3 commits into
python:masterfrom
alex:expose-utf8

Conversation

@alex

@alex alex commented Sep 15, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@alex
alex requested a review from methane September 15, 2020 02:27
@alex
alex requested a review from a team as a code owner September 15, 2020 02:27
methane
methane reviewed Sep 15, 2020
View reviewed changes
Comment thread Include/unicodeobject.h Outdated
serhiy-storchaka
serhiy-storchaka reviewed Sep 15, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also my comments on the tracker.

Comment thread Include/unicodeobject.h Outdated
Comment thread Include/cpython/unicodeobject.h Outdated
@alex

alex commented Sep 15, 2020

Copy link
Copy Markdown
Member Author

Ok, I think I got all the comments. Thanks!

serhiy-storchaka
serhiy-storchaka reviewed Sep 18, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in the documentation something like:

.. versionchanged:: 3.10
   This function is a part of the :ref:`limited API <stable>`.

And add corresponding entry in What's New.

@alex

alex commented Sep 18, 2020

Copy link
Copy Markdown
Member Author

Done

@zooba

zooba commented Oct 19, 2020

Copy link
Copy Markdown
Member

I can't see any What's New entry (I'm looking for Docs/whatsnew/3.10.rst changes). Maybe you added the NEWS entry? I can't tell with all the force pushes (which are unnecessary and only break reviews - we'll squash merge at the end).

@alex

alex commented Oct 19, 2020

Copy link
Copy Markdown
Member Author

Yes, there's a news entry.

@zooba

zooba commented Oct 19, 2020

Copy link
Copy Markdown
Member

That's not the same as a What's New entry: https://docs.python.org/3/whatsnew/3.9.html#c-api-changes

@alex

alex commented Oct 19, 2020

Copy link
Copy Markdown
Member Author

I didn't realize both were needed. I'll add a whatsnew entry now.

@zooba

zooba commented Oct 19, 2020

Copy link
Copy Markdown
Member

Thanks! I fixed the merge conflict, and will merge once CI is done.

@alex

alex commented Oct 19, 2020

Copy link
Copy Markdown
Member Author

Thanks much!

@zooba
zooba merged commit 3a8fdb2 into python:master Oct 19, 2020
@alex
alex deleted the expose-utf8 branch October 19, 2020 22:18
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@alex @adorilson
bpo-41784: make PyUnicode_AsUTF8AndSize part of the limited API (pyth…
8536b57 
…onGH-22252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@methane methane methane left review comments
@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alex @zooba @vstinner @methane @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot